Skip to content

[fix] #161 앨범 상세 즐겨찾기 변경 후 Archive 갱신 누락 수정#186

Merged
ikseong00 merged 1 commit intodevelopfrom
fix/#161-album-detail-favorite-result
Apr 9, 2026
Merged

[fix] #161 앨범 상세 즐겨찾기 변경 후 Archive 갱신 누락 수정#186
ikseong00 merged 1 commit intodevelopfrom
fix/#161-album-detail-favorite-result

Conversation

@ikseong00
Copy link
Copy Markdown
Contributor

🔗 관련 이슈

📙 작업 설명

  • 앨범 상세 화면에서 즐겨찾기 토글 성공 시 NotifyResult를 전송하지 않아 Archive 메인 화면이 갱신되지 않는 문제 수정
  • 다른 작업(이름 변경, 사진 추가, 사진 삭제)과 동일하게 성공 시 AlbumDetailSideEffect.NotifyResult 추가

🧪 테스트 내역 (선택)

  • 주요 기능 정상 동작 확인
  • 기기에서 동작 확인
  • 기존 기능 영향 없음

💬 추가 설명 or 리뷰 포인트 (선택)

  • 즐겨찾기 토글은 낙관적 업데이트로 처리되며, API 실패 시 롤백됨
  • NotifyResult는 API 성공 시에만 전송 (실패 시에는 롤백만)

@ikseong00 ikseong00 added the fix label Apr 9, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Warning

Rate limit exceeded

@ikseong00 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 27 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 12 minutes and 27 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 291f401b-434a-490f-986d-82de72e2a750

📥 Commits

Reviewing files that changed from the base of the PR and between 4d23ae7 and 0eafa79.

📒 Files selected for processing (1)
  • feature/archive/impl/src/main/kotlin/com/neki/android/feature/archive/impl/album_detail/AlbumDetailViewModel.kt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#161-album-detail-favorite-result

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot requested a review from Ojongseok April 9, 2026 17:03
@ikseong00 ikseong00 merged commit 745b798 into develop Apr 9, 2026
3 checks passed
@ikseong00 ikseong00 deleted the fix/#161-album-detail-favorite-result branch April 9, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] Archive Result 수정사항 적용

1 participant