fix: dynamically check model availability based on selected provider#409
Open
romiluz13 wants to merge 1 commit intoZackriya-Solutions:mainfrom
Open
fix: dynamically check model availability based on selected provider#409romiluz13 wants to merge 1 commit intoZackriya-Solutions:mainfrom
romiluz13 wants to merge 1 commit intoZackriya-Solutions:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the "Start Recording" button would be disabled, complaining about a missing transcription model, even when a Whisper model was successfully downloaded and selected.
The bug was caused by a hardcoded check for
parakeet_has_available_modelsinuseRecordingStart.ts. This has been updated to dynamically check the model status based on the selectedtranscriptModelConfig.provider.Additionally, the Whisper engine's
discover_modelsmethod has been enhanced to automatically detect any custom.binmodel files placed in themodelsdirectory, rather than strictly relying on the hardcoded catalog.