Use bigint type for entity_id in the create_version_table.exs example#108
Open
stefanluptak wants to merge 1 commit intoZennerIoT:masterfrom
Open
Use bigint type for entity_id in the create_version_table.exs example#108stefanluptak wants to merge 1 commit intoZennerIoT:masterfrom
stefanluptak wants to merge 1 commit intoZennerIoT:masterfrom
Conversation
Since the `id` column created by default by Ecto is not an `integer` but a `bigint`, it should be the same way in the example to prevent confusion and problems. The `field` definition in the schema itself should still be `integer`, only the migration type is changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
idcolumn created by default by Ecto is not anintegerbut abigint, it should be the same way in the example to prevent confusion and problems.The
fielddefinition in the schema itself should still beinteger, only the migration type is changed.