Skip to content

fix bInterval for usb-hs, units are different between fs and hs #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattnite merged 1 commit into from
Jul 19, 2026
+9 −1
Merged

fix bInterval for usb-hs, units are different between fs and hs #991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion core/src/core/usb/drivers/CDC.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,15 @@ pub const Descriptor = extern struct {
.master_interface = itf_notifi,
.slave_interface_0 = itf_data,
},
.ep_notifi = .interrupt(alloc.next_ep(.In), 8, 16),
// High-speed interrupt intervals are encoded as
// 2^(bInterval - 1) microframes, while full-speed intervals
// are expressed directly in milliseconds. Keep the intended
// polling period at 16 ms for both speeds.
.ep_notifi = .interrupt(
alloc.next_ep(.In),
8,
if (max_supported_packet_size > 64) 8 else 16,
),
.itf_data = .{
.interface_number = itf_data,
.alternate_setting = 0,
Expand Down
Loading