Skip to content
This repository was archived by the owner on Aug 27, 2025. It is now read-only.

Conversation

@vaivaswatha
Copy link
Contributor

@vaivaswatha vaivaswatha commented Jul 27, 2021

These charges, to make it uniform with compiled Scilla, will be charged at the blockchain layer, so we must remove it here from Scilla.

Zilliqa/zq1#2678

The blockchain runs the checker prior to running the interpreter
during a deployment. Since this check must be done at the earliest,
move it to the checker.
@vaivaswatha vaivaswatha changed the title Move cost of parsing from deployment in interpreter to checker Remove gas charges related to source file and input JSONs Jul 28, 2021
Copy link
Contributor

@jjcnn jjcnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something doesn't look right.

I would expect all init output files to have a different gas_remaining with this PR. 31 files of the form init_*.json are changed in this PR, but we appear to have 87 of them in our testsuite:

cnn@tautology:~/Projects/scilla$ ls -la tests/runner/*/init_*.json | wc -l
87

@vaivaswatha
Copy link
Contributor Author

Something doesn't look right.

I would expect all init output files to have a different gas_remaining with this PR. 31 files of the form init_*.json are changed in this PR, but we appear to have 87 of them in our testsuite:

cnn@tautology:~/Projects/scilla$ ls -la tests/runner/*/init_*.json | wc -l
87

You are looking for init_*.json, that would include init JSONs and init state JSONs too. Gas remaining is part of only the output JSONs.

@jjcnn
Copy link
Contributor

jjcnn commented Aug 3, 2021

Something doesn't look right.
I would expect all init output files to have a different gas_remaining with this PR. 31 files of the form init_*.json are changed in this PR, but we appear to have 87 of them in our testsuite:

cnn@tautology:~/Projects/scilla$ ls -la tests/runner/*/init_*.json | wc -l
87

You are looking for init_*.json, that would include init JSONs and init state JSONs too. Gas remaining is part of only the output JSONs.

I'm clearly not on top of my game. :-(

It looks fine, then.

@jjcnn
Copy link
Contributor

jjcnn commented Nov 1, 2021

@vaivaswatha : Status on this?

@vaivaswatha
Copy link
Contributor Author

@vaivaswatha : Status on this?

I can't merge this till Zilliqa/zq1#2678 is done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants