-
Notifications
You must be signed in to change notification settings - Fork 76
Remove gas charges related to source file and input JSONs #1036
base: master
Are you sure you want to change the base?
Conversation
The blockchain runs the checker prior to running the interpreter during a deployment. Since this check must be done at the earliest, move it to the checker.
jjcnn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something doesn't look right.
I would expect all init output files to have a different gas_remaining with this PR. 31 files of the form init_*.json are changed in this PR, but we appear to have 87 of them in our testsuite:
cnn@tautology:~/Projects/scilla$ ls -la tests/runner/*/init_*.json | wc -l
87
You are looking for |
I'm clearly not on top of my game. :-( It looks fine, then. |
|
@vaivaswatha : Status on this? |
I can't merge this till Zilliqa/zq1#2678 is done. |
These charges, to make it uniform with compiled Scilla, will be charged at the blockchain layer, so we must remove it here from Scilla.
Zilliqa/zq1#2678