Fix scalar color type hints for FadeIn and FadeOut#2567
Open
Sev7een wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FadeIn.initial_colorandFadeOut.final_colorto be typed as scalar floats for mask clipsRoot cause
Both effects already support scalar colors at runtime because they convert the provided color with
numpy.array. Their docstrings also document scalar mask colors, but the dataclass annotations only allowedlist. As a result, valid calls such asFadeOut(duration, final_color=0.0)were rejected by static type checkers.Closes #2472
Validation
python -m pytest tests/test_fx.py -q -k "fadein or fadeout"python -m pytestpython -m pytest --doctest-glob "moviepy/**/**.py"black --check --diff --color .isort --check-only --diff moviepy docs/conf.py examples testsflake8 -v --show-source --ignore=E501 moviepy docs/conf.py examples testsAI assistance disclosure
This contribution was prepared with Codex assistance. The final diff and validation results were reviewed locally before submission.