Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces configurable logging for the ITK service, enabling log level control via environment variables and providing detailed request/call logging for both HTTP and gRPC interfaces. It also updates documentation and scripts to support a new debugging workflow involving a mounted logs directory. Feedback was provided regarding the loggingMiddleware implementation, which incorrectly uses slog positional arguments and fails to stop request processing if the body cannot be read, potentially leading to downstream errors.
kdziedzic70
force-pushed
the
dziedzick/improve-itk-logging
branch
from
fba79fc to
6cf441f
Compare
kdziedzic70
requested review from
yarolegovich
and removed request for
yarolegovich
kdziedzic70
force-pushed
the
dziedzick/improve-itk-logging
branch
from
6cf441f to
7a281bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of itk https://github.com/a2aproject/a2a-samples/releases/tag/itk-v.015-alpha improves log readabiulity for debugging by spliting the logs of individual tested agents into separate files if the ITK_LOG_LEVEL environmental variable is set to "DEBUG"
This PR integrates the change into python's sdk CI and updates the instruction on how to set debugging mode for tests