Always installs latest version of code server#112
Open
Mahesha999 wants to merge 1 commit intoabhishekkrthakur:masterfrom
Open
Always installs latest version of code server#112Mahesha999 wants to merge 1 commit intoabhishekkrthakur:masterfrom
Mahesha999 wants to merge 1 commit intoabhishekkrthakur:masterfrom
Conversation
sb0210
reviewed
Jul 5, 2023
| subprocess.run(["wget", "https://code-server.dev/install.sh"], stdout=subprocess.PIPE) | ||
| subprocess.run( | ||
| ["sh", "install.sh", "--version", f"{CODESERVER_VERSION}"], | ||
| # ["sh", "install.sh", "--version", f"{CODESERVER_VERSION}"], |
There was a problem hiding this comment.
Overall Code can be improved.
output of subprocess.run command is not taken care of.
Comments can be removed.
def _install_code():
result = subprocess.run(["wget", "https://code-server.dev/install.sh"], stdout=subprocess.PIPE)
if result.returncode != 0:
raise RuntimeError("Failed to download installation script")
result = subprocess.run(["sh", "install.sh"], stdout=subprocess.PIPE)
if result.returncode != 0:
raise RuntimeError("Failed to run installation script")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes hardcoded vscode version
CODESERVER_VERSION. Thus, it always installs latest version of code server. With hard coded version, I was unable to install the extensions from the vscode extensions marketplace. Also it seems that ngrok now requires users to create authtoken. So, this version might need users to provide their authtoken:Sample colab notebook to boot up with colabcode.