Skip to content

Update the locate db more reliably - #2889

Open
paulapatience wants to merge 1 commit into
abo-abo:masterfrom
paulapatience:counsel-locate
Open

Update the locate db more reliably#2889
paulapatience wants to merge 1 commit into
abo-abo:masterfrom
paulapatience:counsel-locate

Conversation

@paulapatience

Copy link
Copy Markdown

Previously it would be updated only if a file (or directory) named
~/.Private existed.

  • counsel.el (counsel--locate-updatedb): Replace spurious reference to
    ~/.Private with the file-name-directory of counsel-locate-db-path.

Previously it would be updated only if a file (or directory) named
~/.Private existed.

* counsel.el (counsel--locate-updatedb): Replace spurious reference to
~/.Private with the file-name-directory of counsel-locate-db-path.
@basil-conto

basil-conto commented Jul 10, 2021

Copy link
Copy Markdown
Collaborator

Thanks for looking into this!

Replace spurious reference to ~/.Private with the file-name-directory of counsel-locate-db-path.

However, commit b2693d1 that introduced this feature makes it look like the hard-coded ~/.Private was intentional, presumably something specific to @abo-abo's local setup. So I wouldn't be comfortable changing it without comment from @abo-abo. Furthermore, it doesn't look like counsel-locate-db-path and ~/.Private are meant to be the same thing, but then I'm not familiar with this part of Counsel.

@basil-conto basil-conto added the enhancement Suggestion to improve or extend existing behavior label Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Suggestion to improve or extend existing behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants