[BUG 911] isDaytime in PropagationPanel should check local time rather than UTC#912
Open
alanhargreaves wants to merge 3 commits intoaccius:Stagingfrom
Open
[BUG 911] isDaytime in PropagationPanel should check local time rather than UTC#912alanhargreaves wants to merge 3 commits intoaccius:Stagingfrom
alanhargreaves wants to merge 3 commits intoaccius:Stagingfrom
Conversation
…determining if it is daytime. Correct isDaytime to account for sunrise < sunset if we are on teh oter side of the world from UTC and using UTC time
…mezone. For DX locations we display in UTC, explicitly state 'UTC'.
Contributor
|
Shipit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pass currentTime and deSunTimes to
PropagationPaneland use them for determining if it is daytime. CorrectisDaytimeto account for sunrise < sunset if we are on the other side of the world from UTC as we are doing a local sunrise/sunset in UTC.Display sunrise/sunset in local time, ensuring we also display the timezone. For DX locations we display in UTC, explicitly state 'UTC'.
Type of change
How to test
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts included