Skip to content

[BUG 911] isDaytime in PropagationPanel should check local time rather than UTC#912

Open
alanhargreaves wants to merge 3 commits intoaccius:Stagingfrom
alanhargreaves:daytime
Open

[BUG 911] isDaytime in PropagationPanel should check local time rather than UTC#912
alanhargreaves wants to merge 3 commits intoaccius:Stagingfrom
alanhargreaves:daytime

Conversation

@alanhargreaves
Copy link
Copy Markdown
Collaborator

What does this PR do?

Pass currentTime and deSunTimes to PropagationPanel and use them for determining if it is daytime. Correct isDaytime to account for sunrise < sunset if we are on the other side of the world from UTC as we are doing a local sunrise/sunset in UTC.

Display sunrise/sunset in local time, ensuring we also display the timezone. For DX locations we display in UTC, explicitly state 'UTC'.

Type of change

  • Bug fix
  • New feature
  • Performance improvement
  • Refactor / code cleanup
  • Documentation
  • Translation
  • Map layer plugin

How to test

  1. In the propagation panel compare the daytime setting to what you see out the window
  2. Note that in the DE information panel we see the correct sunrise/sunset with the timezone displayed
  3. Note that in the DX information panel that the sunrise/sunset times are listed as UTC

Checklist

  • App loads without console errors
  • Tested in Dark, Light, and Retro themes
  • Responsive at different screen sizes (desktop + mobile)
  • If touching server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)
  • If adding an API route: includes caching and error handling
  • If adding a panel: wired into Modern, Classic, and Dockable layouts
  • Tested in Modern, Classic and Dockable layouts
  • No hardcoded colors — uses CSS variables (var(--accent-cyan), etc.)
  • No .bak, .old, console.log debug lines, or test scripts included

…determining if it is daytime. Correct isDaytime to account for sunrise < sunset if we are on teh oter side of the world from UTC and using UTC time
…mezone. For DX locations we display in UTC, explicitly state 'UTC'.
@alanhargreaves alanhargreaves marked this pull request as ready for review April 15, 2026 10:20
@denete
Copy link
Copy Markdown
Contributor

denete commented Apr 15, 2026

Shipit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] isDaytime in PropagationPanel should check local time rather than UTC

2 participants