template-library(build/htmls): update footer - I404#405
Open
PaarthAgarwal wants to merge 2 commits intoaccordproject:mainfrom
Open
template-library(build/htmls): update footer - I404#405PaarthAgarwal wants to merge 2 commits intoaccordproject:mainfrom
PaarthAgarwal wants to merge 2 commits intoaccordproject:mainfrom
Conversation
Signed-off-by: Paarth Agarwal <paarth.agarwal.mec20@itbhu.ac.in>
PaarthAgarwal
changed the title
jeromesimeon
suggested changes
Feb 4, 2022
Member
jeromesimeon
left a comment
jeromesimeon
left a comment
There was a problem hiding this comment.
hi @PaarthAgarwal thanks for your PR. Two main comments:
- you are changing files that are generated during the build process, instead you should change the source templates for those pages
- I also noticed changes to some of the
.ctaarchives, are those just erroneous updates?
Author
|
prakhar3062
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated copyright year
Changes
changed 'Copyright 2018-2019' to ' Copyright 2018-2022'
Screenshots or Video
Related Issues