chore: migrate acceptance-of-delivery template to cicero v0.25#489
Open
Rishabh060105 wants to merge 1 commit intoaccordproject:mainfrom
Open
chore: migrate acceptance-of-delivery template to cicero v0.25#489Rishabh060105 wants to merge 1 commit intoaccordproject:mainfrom
Rishabh060105 wants to merge 1 commit intoaccordproject:mainfrom
Conversation
Signed-off-by: Rishabh Jain <rishabhjain@Rishabhs-MacBook-Air.local> Signed-off-by: Rishabh Jain <rishabhj2005@email.com>
c328d4c to
aee2fb7
Compare
Contributor
Author
|
Hi, I’ve sent the PR solving the above issue:- Summary of the current state:
The template has been verified end-to-end with the updated request and logic flow. Please let me know if any adjustments are needed or if there are preferred patterns for migrating the remaining templates. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #483
Changes
acceptance-of-deliverytemplate from Ergo (Cicero v0.22) to the TypeScript runtime (v0.25)model/model.ctoto use versioned namespace and importsOrganizationrelationships with string fields forshipperandreceiverlogic.ergo) and cucumber-based test fileslogic/logic.tsusingTemplateLogicconcerto compileinlogic/generatedrequest.jsonto use the new versioned$classlogic/logic.test.ts) covering all execution pathsFlags
acceptance-of-deliverytemplate as an initial step for issue Migrate all templates to the latest version of Cicero #483Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commitmasterfromfork:branchname