Skip to content

chore: migrate acceptance-of-delivery template to cicero v0.25#489

Open
Rishabh060105 wants to merge 1 commit intoaccordproject:mainfrom
Rishabh060105:migrate-cicero-template
Open

chore: migrate acceptance-of-delivery template to cicero v0.25#489
Rishabh060105 wants to merge 1 commit intoaccordproject:mainfrom
Rishabh060105:migrate-cicero-template

Conversation

@Rishabh060105
Copy link
Copy Markdown
Contributor

Closes #483

Changes

  • Migrated the acceptance-of-delivery template from Ergo (Cicero v0.22) to the TypeScript runtime (v0.25)
  • Updated model/model.cto to use versioned namespace and imports
  • Replaced Organization relationships with string fields for shipper and receiver
  • Removed legacy Ergo logic (logic.ergo) and cucumber-based test files
  • Implemented contract logic in logic/logic.ts using TemplateLogic
  • Generated TypeScript typings using concerto compile in logic/generated
  • Updated request.json to use the new versioned $class
  • Added Jest-based unit tests (logic/logic.test.ts) covering all execution paths

Flags

Screenshots or Video

  • Not applicable

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

Signed-off-by: Rishabh Jain <rishabhjain@Rishabhs-MacBook-Air.local>
Signed-off-by: Rishabh Jain <rishabhj2005@email.com>
@Rishabh060105 Rishabh060105 force-pushed the migrate-cicero-template branch from c328d4c to aee2fb7 Compare March 24, 2026 10:40
@Rishabh060105
Copy link
Copy Markdown
Contributor Author

Hi, I’ve sent the PR solving the above issue:-

Summary of the current state:

  • Migration from Ergo (v0.22) to TypeScript runtime (v0.25) is complete
  • Model updated to versioned namespace and imports
  • Legacy artifacts (Ergo logic, cucumber tests, state files) removed
  • TypeScript logic implemented using TemplateLogic
  • Generated typings added via concerto compile
  • Jest-based tests added and all test cases are passing locally

The template has been verified end-to-end with the updated request and logic flow.

Please let me know if any adjustments are needed or if there are preferred patterns for migrating the remaining templates.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate all templates to the latest version of Cicero

1 participant