fix(docs): correct broken internal links in vocabulary and quick-start#126
Open
ospreyboi wants to merge 1 commit intoaccordproject:mainfrom
Open
fix(docs): correct broken internal links in vocabulary and quick-start#126ospreyboi wants to merge 1 commit intoaccordproject:mainfrom
ospreyboi wants to merge 1 commit intoaccordproject:mainfrom
Conversation
Signed-off-by: ospreyboi <akshaosprey460@gmail.com>
✅ Deploy Preview for concerto-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
@sanketshevkar could you please review this PR and telll if anymore changes are required? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While going through the docs
I noticed two internal links were broken and leading to 404 pages.
After digging in, I found both were using absolute Docusaurus
paths (
/docs/...) instead of relative paths which is whatwas causing them to break.
Fixed the following:
docs/design/vocabulary.mdthe link to the JS APIreference was using
/docs/reference/api/ref-concerto-js-api,changed it to "../reference/api/ref-concerto-js-api"
"docs/tutorials/quick-start.md " on line 149 the link to the JS
validation API was pointing to a non-existent page
api-js-validation, corrected it tousing-js-validationI have verified both the fixe locally on localhost:3000, there are no 404s errors anymore.
very Sorry about the messy previous PR #122 — I had included some
usless casing changes which were not needed . This PR is
focused on the link fixes only.
Author Checklist
ospreyboi:fix/broken-links-506Closes #506