chore: add TypeScript + Jest test setup and update README #1153#1154
chore: add TypeScript + Jest test setup and update README #1153#1154Ananya-vastare wants to merge 1 commit intoaccordproject:mainfrom
Conversation
Signed-off-by: Ananya Vastare <116643029+Ananya-vastare@users.noreply.github.com>
e5e5b7d to
1289671
Compare
divyansh-cyber
left a comment
There was a problem hiding this comment.
Nice progress on this PR, and the TypeScript + Jest setup direction looks good overall.
One suggestion before merge, the new no-duplicate-declarations test currently only checks that a model variable is a string, so it doesn’t validate actual linter behavior and may give false confidence. Since this issue is primarily setup/tooling for the default ruleset, I’d recommend either,
Removing that test from this PR to keep scope focused on config/docs, orUpdating it to run the ruleset and assert real lint results (for example, expected violation code/message/count for duplicate declarations).
Everything else looks aligned with the issue goal and improves contributor experience.
|
@divyansh-cyber Thanks for the feedback! I see your point about the current no-duplicate-declarations test — it does just check a string rather than fully validating the linter behavior, which could indeed give false confidence. |
happy to make a fix there |
This PR updates the
tsconfig.jsonto include thetestdirectory in the TypeScript compilation and fixes related linting issues, ensuring all source and test files are correctly recognized.Changes
tsconfig.jsonto include"test/**/*.ts"in theincludearray.rootDir.srcandtestdirectories.Flags
Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchnameis okay.