BaseTools/Source/C: Remove duplicate -fshort-wchar#87
Draft
mikebeaton wants to merge 1 commit intoacidanthera:masterfrom
Draft
BaseTools/Source/C: Remove duplicate -fshort-wchar#87mikebeaton wants to merge 1 commit intoacidanthera:masterfrom
mikebeaton wants to merge 1 commit intoacidanthera:masterfrom
Conversation
mikebeaton
force-pushed
the
short-wchar
branch
from
2a7e352 to
892f91b
Compare
`-fshort-wchar -flto -DUSING_LTO` was added via CPPFLAGS to all relevant uses of gcc and g++ in commit 2f61ab9. However CFLAGS, as defined in the lines above that change, is never consumed without CPPFLAGS, therefore `-fshort-wchar` can be removed from CFLAGS to avoid it appearing twice in every call to gcc which uses CFLAGS. Note that the affected files within BaseTools/Source/C (those that include the changed file, and all those that those include) are: ``` Makefiles/app.makefile Makefiles/lib.makefile GNUmakefile VfrCompile/GNUmakefile Makefiles/footer.makefile Makefiles/header.makefile ``` Note also that in VfrCompile/GNUmakefile g++ is affected by CPPFLAGS, but not CXXFLAGS. Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>
mikebeaton
force-pushed
the
short-wchar
branch
from
892f91b to
8609fbf
Compare
Member
Author
|
Can't see why tianocore/edk2#11779 is failing, but putting this to draft status too as a precaution, until resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-fshort-wchar -flto -DUSING_LTOwas added via CPPFLAGS to all relevant uses of gcc and g++ in commit 2f61ab9.However CFLAGS, as defined in the lines above that change, is never consumed without CPPFLAGS, therefore
-fshort-wcharcan be removed from CFLAGS to avoid it appearing twice in every call to gcc which uses CFLAGS.Note that the affected files within BaseTools/Source/C (those that include the changed file, and all those that those include) are:
Note also that in VfrCompile/GNUmakefile g++ is affected by CPPFLAGS, but not CXXFLAGS.
How This Was Tested
Confirm in BaseTools/Source/C build console output prior to change that all single and double appearances of
-fshort-wcharmatch the pattern mentioned. Confirm compiled executables before and after change are the same size (they are not binary identical, and differ at multiple locations, but this is believed to be as expected due to meta-data).Integration Instructions
N/A