Open
Conversation
We want to display the total deposited BTC not the current balance in the stats card.
Rename to `Account Summary` and display the BTC balance with USD conversion instead of the acreBTC balance.
✅ Deploy Preview for acre-dapp-v1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
nkuba
reviewed
Nov 17, 2025
dapp/src/hooks/usePositionStats.ts
Outdated
| }, | ||
| enabled: isInitialized && isConnected && !!acre, | ||
| }) | ||
| return { deposited: sumOfDeposits, earned: earned < 0n ? 0n : earned } |
Collaborator
There was a problem hiding this comment.
We need to clarify with Product the actual intention of the deposited value to be shown. Currently the user can deposit and withdraw in the loop, and their BTC Deposited value will be growing, while they are looping the same deposit amont.
Contributor
Author
There was a problem hiding this comment.
I updated to:
"BTC deposited" ==> net active BTC deposits. (total aggregate # of BTC that has been deposited by the user) - (total aggregate BTC withdrawals).
The "BTC deposited" means net active BTC deposits. (total aggregate number of BTC that has been deposited by the user) - (total aggregate BTC withdrawals).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://linear.app/acrefi/issue/ACR-88/copy-update-current-balance
Closes: https://linear.app/acrefi/issue/ACR-154/current-balance-does-not-update-upon-withdrawal-until-after-refresh
This PR updates the main stats card on the dashboard page - we want to display the total deposited BTC not the current balance in the stats card. Here we also rename the position section to
Account Summaryand display the BTC balance with USD conversion instead of the acreBTC balance.