Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three mouse wheel actions, each gated by a configurable modifier using HotkeySpec.
I've tried to follow existing patterns to the best of my ability, and
parse_mods_and_optional_keyin hotkey.rs was made pub so the mouse wheel config can reuse the existing modifier parsing via HotkeySpec rather than duplicating it, which was my initial approach.Have tested all three actions on a magic mouse, a janky old office mouse and the trackpad. Input is accumulated to handle continuous scrolling from mm, trackpad etc.
Mouse wheel handlers are built inside build_gesture_handlers since they share the same config reload lifecycle, but this might warrant a rename to something like build_input_handlers for clarity, unless a full separation of concerns is wanted.
A suggestion for default config was tossed in there based on how I personally use it, but obviously feel free to move this around if it feels more logical elsewhere.