Skip to content

Update to xunit.v3 and Microsoft.Testing.Platform #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Youssef1313 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update to xunit.v3 and Microsoft.Testing.Platform #4170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b42240f
Update to xunit.v3 and Microsoft.Testing.Platform
Youssef1313 Dec 21, 2025
21858cf
async void -> async Task
Youssef1313 Dec 21, 2025
d5d814c
NoWarn
Youssef1313 Dec 21, 2025
4f4e6f4
Missing using
Youssef1313 Dec 21, 2025
096f745
Fix dotnet test invocation
Youssef1313 Dec 21, 2025
2666f6a
TRX
Youssef1313 Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"sdk": {
"version": "10.0.101"
},
"test": {
"runner": "Microsoft.Testing.Platform"
}
}
2 changes: 2 additions & 0 deletions src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,7 @@
<NuGetAuditMode>all</NuGetAuditMode>
<!-- Report low, moderate, high and critical advisories -->
<NuGetAuditLevel>moderate</NuGetAuditLevel>

<UseMicrosoftTestingPlatformRunner>true</UseMicrosoftTestingPlatformRunner>
</PropertyGroup>
</Project>
8 changes: 4 additions & 4 deletions src/Test/L0/Listener/ErrorThrottlerL0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public sealed class ErrorThrottlerL0
[InlineData(6)]
[InlineData(7)]
[InlineData(8)]
public async void TestIncrementAndWait(int totalAttempts)
public async Task TestIncrementAndWait(int totalAttempts)
{
using (TestHostContext hc = CreateTestContext())
{
Expand Down Expand Up @@ -97,7 +97,7 @@ public async void TestIncrementAndWait(int totalAttempts)
}

[Fact]
public async void TestReset()
public async Task TestReset()
{
using (TestHostContext hc = CreateTestContext())
{
Expand Down Expand Up @@ -151,7 +151,7 @@ public async void TestReset()
}

[Fact]
public async void TestReceivesCancellationToken()
public async Task TestReceivesCancellationToken()
{
using (TestHostContext hc = CreateTestContext())
{
Expand Down Expand Up @@ -180,7 +180,7 @@ public async void TestReceivesCancellationToken()
}

[Fact]
public async void TestReceivesSender()
public async Task TestReceivesSender()
{
using (TestHostContext hc = CreateTestContext())
{
Expand Down
24 changes: 12 additions & 12 deletions src/Test/L0/Listener/JobDispatcherL0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private Pipelines.AgentJobRequestMessage CreateJobRequestMessage(string billingO
[Trait("Category", "Runner")]
[InlineData(null)]
[InlineData("billingOwnerId")]
public async void DispatchesJobRequest(string billingOwnerId)
public async Task DispatchesJobRequest(string billingOwnerId)
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down Expand Up @@ -102,7 +102,7 @@ public async void DispatchesJobRequest(string billingOwnerId)
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void DispatcherRenewJobRequest()
public async Task DispatcherRenewJobRequest()
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down Expand Up @@ -160,7 +160,7 @@ public async void DispatcherRenewJobRequest()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void DispatcherRenewJobRequestStopOnJobNotFoundExceptions()
public async Task DispatcherRenewJobRequestStopOnJobNotFoundExceptions()
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down Expand Up @@ -219,7 +219,7 @@ public async void DispatcherRenewJobRequestStopOnJobNotFoundExceptions()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void DispatcherRenewJobOnRunServiceStopOnJobNotFoundExceptions()
public async Task DispatcherRenewJobOnRunServiceStopOnJobNotFoundExceptions()
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down Expand Up @@ -288,7 +288,7 @@ public async void DispatcherRenewJobOnRunServiceStopOnJobNotFoundExceptions()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void DispatcherRenewJobRequestStopOnJobTokenExpiredExceptions()
public async Task DispatcherRenewJobRequestStopOnJobTokenExpiredExceptions()
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down Expand Up @@ -347,7 +347,7 @@ public async void DispatcherRenewJobRequestStopOnJobTokenExpiredExceptions()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void RenewJobRequestNewAgentNameUpdatesSettings()
public async Task RenewJobRequestNewAgentNameUpdatesSettings()
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down Expand Up @@ -404,7 +404,7 @@ public async void RenewJobRequestNewAgentNameUpdatesSettings()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void RenewJobRequestSameAgentNameIgnored()
public async Task RenewJobRequestSameAgentNameIgnored()
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down Expand Up @@ -459,7 +459,7 @@ public async void RenewJobRequestSameAgentNameIgnored()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void RenewJobRequestNullAgentNameIgnored()
public async Task RenewJobRequestNullAgentNameIgnored()
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down Expand Up @@ -512,7 +512,7 @@ public async void RenewJobRequestNullAgentNameIgnored()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void DispatcherRenewJobRequestRecoverFromExceptions()
public async Task DispatcherRenewJobRequestRecoverFromExceptions()
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down Expand Up @@ -573,7 +573,7 @@ public async void DispatcherRenewJobRequestRecoverFromExceptions()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void DispatcherRenewJobRequestFirstRenewRetrySixTimes()
public async Task DispatcherRenewJobRequestFirstRenewRetrySixTimes()
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down Expand Up @@ -628,7 +628,7 @@ public async void DispatcherRenewJobRequestFirstRenewRetrySixTimes()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void DispatcherRenewJobRequestStopOnExpiredRequest()
public async Task DispatcherRenewJobRequestStopOnExpiredRequest()
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down Expand Up @@ -694,7 +694,7 @@ public async void DispatcherRenewJobRequestStopOnExpiredRequest()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void DispatchesOneTimeJobRequest()
public async Task DispatchesOneTimeJobRequest()
{
//Arrange
using (var hc = new TestHostContext(this))
Expand Down
8 changes: 4 additions & 4 deletions src/Test/L0/Listener/SelfUpdaterL0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ private async Task FetchLatestRunner()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void TestSelfUpdateAsync()
public async Task TestSelfUpdateAsync()
{
try
{
Expand Down Expand Up @@ -137,7 +137,7 @@ public async void TestSelfUpdateAsync()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void TestSelfUpdateAsync_NoUpdateOnOldVersion()
public async Task TestSelfUpdateAsync_NoUpdateOnOldVersion()
{
try
{
Expand Down Expand Up @@ -188,7 +188,7 @@ public async void TestSelfUpdateAsync_NoUpdateOnOldVersion()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void TestSelfUpdateAsync_DownloadRetry()
public async Task TestSelfUpdateAsync_DownloadRetry()
{
try
{
Expand Down Expand Up @@ -241,7 +241,7 @@ public async void TestSelfUpdateAsync_DownloadRetry()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void TestSelfUpdateAsync_ValidateHash()
public async Task TestSelfUpdateAsync_ValidateHash()
{
try
{
Expand Down
6 changes: 3 additions & 3 deletions src/Test/L0/Listener/SelfUpdaterV2L0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ private async Task FetchLatestRunner()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void TestSelfUpdateAsync()
public async Task TestSelfUpdateAsync()
{
try
{
Expand Down Expand Up @@ -134,7 +134,7 @@ public async void TestSelfUpdateAsync()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void TestSelfUpdateAsync_DownloadRetry()
public async Task TestSelfUpdateAsync_DownloadRetry()
{
try
{
Expand Down Expand Up @@ -183,7 +183,7 @@ public async void TestSelfUpdateAsync_DownloadRetry()
[Fact]
[Trait("Level", "L0")]
[Trait("Category", "Runner")]
public async void TestSelfUpdateAsync_ValidateHash()
public async Task TestSelfUpdateAsync_ValidateHash()
{
try
{
Expand Down
Loading