Fix yarn generate:icons command#7281
Open
JSkinnerUK wants to merge 7 commits intoactualbudget:masterfrom
Open
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
👋 Hello contributor! We would love to review your PR! Before we can do that, please make sure:
We do this to reduce the TOIL the core contributor team has to go through for each PR and to allow for speedy reviews and merges. For more information, please see our Contributing Guide. |
✅ Deploy Preview for actualbudget-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
matt-fidd
approved these changes
Mar 25, 2026
Member
matt-fidd
left a comment
There was a problem hiding this comment.
Brilliant, thank you for looking into this!
joel-jeremy
approved these changes
Mar 25, 2026
youngcw
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I believe this is a prerequisite to properly test the remaining task in #1483
Most files touched in this PR, are the result of running the fixed
yarn generate:icons. To limit the changes, I set prettier to singleQuote for this generation.In order to fix the
yarn generate:iconscommand, three errors were needed to be addressed,:The change from
module.exports =toexport defaulttotemplate.tsandindex-template.tswas to address the below. I tracked down the cause of this error to be by commit 30bc216Then, I added the
@svgr/babel-plugin-add-jsx-attributedependency topackages/component-library/package.jsonto fix the below. I've not tracked down exactly where this stopped working as I did for the above issue.Finally, there did not exist a chart-area.svg for some reason, which after generating resulted in a failed typecheck. So I created it the SVG from the the corresponding, existing tsx file.
Related issue(s)
Fixes #7280
Testing
I considered adding to check.yml, but think that would be a bit overkill, potentially blocking things for an rarely used feature. Happy to add / do something else though if you think worthwhile.
Checklist
Bundle Stats
View detailed bundle stats
desktop-client
Total
Changeset
home/runner/work/actual/actual/packages/component-library/src/icons/v2/Sum.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/NotesPaper.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Reports.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Subtract.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v0/Subtract.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/Subtract.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/ArrowsShrink3.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Cog.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/CheckCircleHollow.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/Calendar.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/PencilWriteAlternate.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Add.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v0/Add.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/NotesPaperText.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Equals.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/Pencil1.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Location.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Bookmark.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ArrowThickRight.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ArrowThickDown.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ArrowThickUp.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/UncheckAll.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Wallet.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/AlertTriangle.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/DotsHorizontalTriple.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/ViewShow.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/CustomNotesPaper.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/ValidationCheck.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v0/LeftArrow2.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Question.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/CheckCircle1.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Pin.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/FavoriteStar.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/LockClosed.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/LockOpen.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/Key.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Filter.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Camera.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/Calendar3.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/ArrowButtonSingleLeft1.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/Sun.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/SearchAlternate.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ExclamationSolid.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Copy.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/ArrowButtonRight1.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/ArrowButtonDown1.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/ArrowButtonLeft1.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/ArrowButtonUp1.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Code.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/RefreshArrow.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/Hyperlink2.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ArrowThinLeft.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/DownloadThickBottom.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ArrowLeft.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/InformationOutline.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ArrowUp.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ExclamationOutline.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/FileDouble.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/EditSkull1.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Tag.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/CheckAll.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/ArrowsExpand3.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ChartPie.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/Check.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/Help.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/User.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/ViewHide.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Close.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Queue.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/PiggyBank.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/LightBulb.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/System.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ChartBar.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/StoreFront.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/CheveronRight.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/CreditCard.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/CloudDownload.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/ArrowsSynchronize.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/UserGroup.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Trash.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/logo/Logo.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/DownAndRightArrow.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/CloudUnknown.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Library.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v0/RightArrow2.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ListBullet.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Refresh.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/CloudCheck.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Chart.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Tuning.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Calculator.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/MoonStars.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/Calendar.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v0/ExpandArrow.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/CloseParenthesis.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v2/OpenParenthesis.tsxhome/runner/work/actual/actual/packages/component-library/src/icons/v1/ChartArea.tsxView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
Unchanged
loot-core
Total
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
api
Total
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
cli
Total
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged