Fix float literals and implicit conversions#213
Open
da-phil wants to merge 2 commits intoadafruit:masterfrom
Open
Fix float literals and implicit conversions#213da-phil wants to merge 2 commits intoadafruit:masterfrom
da-phil wants to merge 2 commits intoadafruit:masterfrom
Conversation
da-phil
force-pushed
the
fix_implicit_float_conversions
branch
from
fe4bddc to
dd4cacb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is a lot of double literals all over the codebase, which need to be implicitly converted to floats in all caclucations with float variables.
This PR changes
pow->powf,sqrt->sqrtf)Those changes mostly impact the heat index calculation (
computeHeatIndex()) which runs around 2x faster with the proposed changes on my Arduino MKR1000 WiFi.