add begin() with device type, so device type can be set in SETUP() after being read from a config source#78
Open
species5618 wants to merge 6 commits intoadafruit:masterfrom
Open
add begin() with device type, so device type can be set in SETUP() after being read from a config source#78species5618 wants to merge 6 commits intoadafruit:masterfrom
species5618 wants to merge 6 commits intoadafruit:masterfrom
Conversation
added void DHT::begin(uint8_t type)
void DHT::begin(uint8_t type);
ADD Ability to change sensor type after instantiation for use with a configuration PCB i am developing void DHT::begin(uint8_t type);
typo
copy and paste error
…ter being read from a config source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
really simple change to support my use case
i have a ESP8266 board which i plan to fit DHT11 or DHT22 to, the type will vary depending on use,
rather than recompile my code each time, i need to be able to set the device type at runtime (via a configuration file (SPIFFS), web page on ESP8266) not design time
adding an additional constructor which does not require type to be specified
adding an additional begin() which accepts device type
achieves this, as it allows me to set the device type in the setup section after fetching and configuration from SPIFFS
DHT.zip