fix: overlay positioning for v3 submenus (aka non viewport containers)#9343
fix: overlay positioning for v3 submenus (aka non viewport containers)#9343
Conversation
|
Build successful! 🎉 |
snowystinger
left a comment
There was a problem hiding this comment.
Tested against #7654 and while it doesn't cause flipping, it does stop it from rendering the popover completely out of view, so it's an improvement for that. I tested some other PRs which appear to have been fixed along the way and didn't find a regression with this change.
I tested in various popover stories with different window widths and heights as well as with position relative etc and didn't find any new issues.
|
Other PRs to check against: |
|
Build successful! 🎉 |
|
@snowystinger I forgot to revert the previous changes where we duplicated the old calculatePosition code which may have influenced the testing results, pushed an update. Additionally, I tested against #6333 but unfortunately still got the same issue, we will have to investigate that separately. I have the test story stashed locally, lemme know if you wanna check it out |
|
Build successful! 🎉 |
|
merging for testing, will need to make a call if it is worth the risk over the current approach |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
Go to the v3 Submenu docs and verify that the submenu renders as expected
🧢 Your Project: