fix(RAC): use ICB size as the fallback value for visual viewport #9384
+19
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specification, the visual viewport size excludes the scrollbar. Instead of
window.innerWidth/Height, the fallback value should bedocument.documentElement.clientWidth/Height, which is the same as the ICB size and almost equivalent to the visual viewport size, which excludes the scrollbar.It's mainly a fix about code correctness, as the
VisualViewportis widely supported today.See: https://drafts.csswg.org/cssom-view/#visualViewport
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: