chore(ci): fix e2e workflow auth for private git dependency#1866
Merged
chore(ci): fix e2e workflow auth for private git dependency#1866
Conversation
The e2e-tests workflow was missing the MYSTICAT_DATA_SERVICE_REPO_READ_TOKEN env var on the setup-node-npm step, causing npm ci to fail when resolving the private mysticat-data-service git dependency. Also added persist-credentials: false to prevent the GITHUB_TOKEN credential helper from overriding the git URL rewrite. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
blefebvre
approved these changes
Feb 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
🎉 This PR is included in version 1.324.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MYSTICAT_DATA_SERVICE_REPO_READ_TOKENenv var to thesetup-node-npmstep in the e2e-tests workflowpersist-credentials: 'false'to the checkout step to prevent theGITHUB_TOKENcredential helper from overriding the git URL rewriteThe e2e workflow was failing on
npm cibecause it couldn't resolve the privatemysticat-data-servicegit dependency. The CI workflow (ci.yaml) already has both of these configured correctly — this brings the e2e workflow in line.Test plan
🤖 Generated with Claude Code