Skip to content

feat: add timesCited to SentimentTopic and reject duplicate topic names#1896

Open
HollywoodTonight wants to merge 8 commits intomainfrom
guidelines-store-times-cited
Open

feat: add timesCited to SentimentTopic and reject duplicate topic names#1896
HollywoodTonight wants to merge 8 commits intomainfrom
guidelines-store-times-cited

Conversation

@HollywoodTonight
Copy link
Contributor

  • Add timesCited (integer, default 0) to DTO, controller, and OpenAPI spec
  • POST createTopics now rejects duplicate names (case-insensitive) as per-item failures, both against existing topics and within the batch
  • PATCH updateTopic now supports updating timesCited
  • Update unit tests, integration tests, and seed data

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description. Or if there's no issue created, make sure you
    describe here the problem you're solving.
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

If the PR is changing the API specification:

  • make sure you add a "Not implemented yet" note the endpoint description, if the implementation is not ready
    yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
  • make sure you add at least one example of the request and response.

If the PR is changing the API implementation or an entity exposed through the API:

  • make sure you update the API specification and the examples to reflect the changes.

If the PR is introducing a new audit type:

  • make sure you update the API specification with the type, schema of the audit result and an example

Related Issues

Thanks for contributing!

- Add timesCited (integer, default 0) to DTO, controller, and OpenAPI spec
- POST createTopics now rejects duplicate names (case-insensitive) as
  per-item failures, both against existing topics and within the batch
- PATCH updateTopic now supports updating timesCited
- Update unit tests, integration tests, and seed data

Made-with: Cursor
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

This PR will trigger a minor release when merged.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Replace flat timesCited integer with a citations array that tracks
per-URL citation counts. Updated DTO, controller, OpenAPI spec,
and all tests.

Made-with: Cursor
Add categories (string array) to DTO, controller, OpenAPI spec,
and all tests.

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant