Skip to content

fix: improve import service E2E test diagnostics#1938

Open
blefebvre wants to merge 2 commits intomainfrom
fix/e2e-import-test-diagnostics
Open

fix: improve import service E2E test diagnostics#1938
blefebvre wants to merge 2 commits intomainfrom
fix/e2e-import-test-diagnostics

Conversation

@blefebvre
Copy link
Contributor

  • The issue this PR is addressing is that failed E2E tests are difficult to debug, as the logs reveal little about the failure. Before:
AssertionError: expected false to be true
  • With this change:
AssertionError: Expected 202 Accepted but got 429: Too Many Requests: API key hash b3523cc4472ccdfa__example__58de2066caed04e cannot be used to start any more import jobs for [https://implementationdetails.dev:](https://implementationdetails.dev/) expected false to be true
  • Include HTTP status and x-error header in assertion failure message so the root cause of import job creation failures is visible in CI output
  • Add USER_API_KEY env var to e2e workflow so suggestions-projection tests are no longer silently skipped when the secret is configured

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description. Or if there's no issue created, make sure you
    describe here the problem you're solving.
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

If the PR is changing the API specification:

  • make sure you add a "Not implemented yet" note the endpoint description, if the implementation is not ready
    yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
  • make sure you add at least one example of the request and response.

If the PR is changing the API implementation or an entity exposed through the API:

  • make sure you update the API specification and the examples to reflect the changes.

If the PR is introducing a new audit type:

  • make sure you update the API specification with the type, schema of the audit result and an example

…Y to workflow

- Include HTTP status and x-error header in assertion failure message so
  the root cause of import job creation failures is visible in CI output
- Add USER_API_KEY env var to e2e workflow so suggestions-projection tests
  are no longer silently skipped when the secret is configured

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@blefebvre blefebvre requested a review from ekremney March 10, 2026 20:51
@blefebvre blefebvre self-assigned this Mar 10, 2026
…elpers

Include HTTP status, x-error header, and relevant context (job ID, URL)
in every assertion failure message so CI output identifies the root cause
without needing to re-run tests locally.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link

This PR will trigger a patch release when merged.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant