Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,17 @@ export const DATA_SCHEMAS = {
pageviews: Joi.number().optional(),
clsCount: Joi.number().optional(),
ttfbCount: Joi.number().optional(),
lcp: Joi.number().optional(),
lcp: Joi.number().allow(null).optional(),
inpCount: Joi.number().optional(),
inp: Joi.number().optional(),
ttfb: Joi.number().optional(),
cls: Joi.number().optional(),
ttfb: Joi.number().allow(null).optional(),
cls: Joi.number().allow(null).optional(),
lcpCount: Joi.number().optional(),
organic: Joi.number().optional(),
}).unknown(true),
).required(),
issues: Joi.array().items(Joi.object()).required(),
jiraLink: Joi.string().uri().allow(null).optional(),
aggregationKey: Joi.string().allow(null).optional(),
}).unknown(true),
projections: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,62 @@ describe('SuggestionModel', () => {
Suggestion.validateData({ anything: 'goes' }, 'unknown-type');
}).to.not.throw();
});

// Verification: CWV suggestion data (suggestion.data object only) vs DATA_SCHEMAS['cwv']
describe('CWV opportunity type', () => {
it('passes when url-type has type, url (uri), metrics, and issues', () => {
const suggestionData = {
type: 'url',
url: 'https://www.example.com/page',
pageviews: 11620,
organic: 2400,
metrics: [
{
deviceType: 'mobile',
pageviews: 6200,
lcp: 2701,
cls: 0.001,
ttfb: 682,
},
{
deviceType: 'desktop',
pageviews: 3600,
lcp: null,
cls: null,
ttfb: null,
},
],
issues: [],
};
expect(() => Suggestion.validateData(suggestionData, 'cwv')).to.not.throw();
});

it('fails when issues is missing (schema requires issues array)', () => {
const suggestionData = {
type: 'url',
url: 'https://www.example.com/page',
pageviews: 11620,
metrics: [{ deviceType: 'mobile', lcp: 2701 }],
};
expect(() => Suggestion.validateData(suggestionData, 'cwv')).to.throw();
});

it('fails when group-type has pattern but no url (schema requires url)', () => {
const suggestionData = {
type: 'group',
name: 'Some pages',
pattern: 'https://www.aem.live/home/*',
pageviews: 9620,
organic: 1900,
metrics: [
{ deviceType: 'desktop', lcp: 2099, cls: 0.011 },
{ deviceType: 'mobile', lcp: 2454, cls: 0.27 },
],
issues: [],
};
expect(() => Suggestion.validateData(suggestionData, 'cwv')).to.throw();
});
});
});
});
});
Loading