Closed
Conversation
added 30 commits
January 2, 2020 13:08
aerinon
approved these changes
Mar 22, 2020
aerinon
requested changes
Mar 23, 2020
Owner
There was a problem hiding this comment.
Unfortunately, the approval was premature.
Two items that needs to be addressed:
- convert the invalid_dungeon_bunny_revival regions to the new DR regions - right now, you would be required to Dungeon Bunny Revive places you really can't. DR is much more granular and probably should include the SW Pots as well.
- rewrite the find_inaccessible_regions functions to ignore these new glitched connections when OWG is not on. Right now, it would create dungeon layouts requiring the glitches and then fail to generate the seed when checking if the world is still beatable using all the rules
Author
|
Updated the bunny revival regions. I admit I have no idea what to do about the find_inaccessible_regions function. Could we just not add the new connections if OWG is not on so that it can't use them? |
|
Yes, it looks like we need to only add the new connections if OWG is on (in link_entrances / link_inverted_entrances). The current solution of creating all the connections and setting them to invalid in set_rules is fine for the entrance randomiser, but doesn't work here. Theoretically, Skull Woods Pot Circle is ok because you get superbunny state. But banning that is fine. |
Owner
|
Believe this all got into DoorDev branch now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to add OWG logic done by qadan, I just cleaned up the merge conflicts.
Upstream PRs have been made already, refer:
Bonta0#23
KevinCathcart#17