Skip to content

Fix SVG attributes preserve aspect ratio and view box#170

Open
ashadulhoque wants to merge 2 commits intoaerkalov:masterfrom
ashadulhoque:fix-svg-attribure-preserveAspectRatio-and-viewBox
Open

Fix SVG attributes preserve aspect ratio and view box#170
ashadulhoque wants to merge 2 commits intoaerkalov:masterfrom
ashadulhoque:fix-svg-attribure-preserveAspectRatio-and-viewBox

Conversation

@ashadulhoque
Copy link

lxml processing at class EpubHtml converts preserveAspectRatio and viewBox svg attributes to lowercase which generates epub validation error and resultant epub cover doesn't cover full page as it should. This hack restores the case of these attributes.

@james-c-barnes
Copy link

Just ran into this bug; 'viewBox' is renamed to 'viewbox'. Code hack works. I needed to convert the strings to bytes

        # https://github.com/aerkalov/ebooklib/pull/170
        tree_str = tree_str.replace(b'preserveaspectratio',b'preserveAspectRatio')
        tree_str = tree_str.replace(b'viewbox',b'viewBox')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants