This repository was archived by the owner on Mar 13, 2025. It is now read-only.
Unify triangle_index for indexed and non-indexed meshes#117
Open
brookman wants to merge 4 commits intoaevyrie:mainfrom
Open
Unify triangle_index for indexed and non-indexed meshes#117brookman wants to merge 4 commits intoaevyrie:mainfrom
brookman wants to merge 4 commits intoaevyrie:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For indexed meshes
triangle_indexcontained the (looked up / resolved) index of the first vertex of the triangle. This made it impossible to find the other two vertices because there was no data on the triangle (one vertex can belong to multiple triangles).This PR unifies the way how indexed and non-indexed meshes are handled without increasing the size of the
IntersectionDatastruct. In turn the users have to implement the lookup of the indices themselves. In my case I'm using a function like this:Maybe this could be added as convenience function to
IntersectionDataorMeshin the future?This PR addresses the issues discussed here: