feat: add image uploads for items and marks#19
Merged
Conversation
- Add Image model with item_id/mark_id foreign keys and CHECK constraint
- Add async R2 storage service (upload, delete, bulk delete) via aioboto3
- Add item image endpoints: POST/GET/DELETE /items/{item_id}/images (max 10)
- Add mark image endpoints: POST/GET/DELETE /items/{item_id}/marks/{mark_id}/images (max 3)
- Add file validation (JPEG/PNG/WebP, 10MB max)
- Add R2 config settings with production validation
- Add best-effort R2 cleanup on item/mark deletion
- Add images relationship to Item and Mark models
- Add ImageRead to ItemRead and MarkRead schemas
- Add 20 tests covering uploads, deletes, validation, limits, and user isolation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
uv run pytest— 111 tests passing (20 new)