-
Notifications
You must be signed in to change notification settings - Fork 19
Fix/pin streamlit version #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pin the exact streamlit version to ensure consistent UI appearance across different server environments.
Pin additional UI-related dependencies to ensure consistent appearance across different server environments: - altair==5.5.0 (chart rendering) - nest-asyncio==1.6.0 (async support)
Summary of ChangesHello @XiaoBoAI, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the stability and predictability of the UI environment by explicitly pinning key Python dependencies to specific versions. This change aims to prevent potential compatibility issues that might arise from automatic updates of these libraries, ensuring a more consistent development and deployment experience for the Streamlit-based user interface. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request pins the versions for streamlit and nest-asyncio, and adds a pinned version of altair. This is an excellent change that improves the reproducibility of the environment by locking dependencies. The changes are a clear improvement. I've added one suggestion to consider using a tool like pip-tools to further enhance dependency management by automatically pinning all transitive dependencies, which would be beneficial for long-term maintainability.
| streamlit==1.46.1 | ||
|
|
||
| # Streamlit chart library (pin to ensure consistent chart rendering) | ||
| altair==5.5.0 | ||
|
|
||
| # For async support in Streamlit | ||
| nest-asyncio>=1.6.0 | ||
| nest-asyncio==1.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning direct dependencies with == is a great step towards creating reproducible environments. To further improve this and ensure long-term maintainability, consider using a tool like pip-tools.
With pip-tools, you would maintain a requirements.in file with your high-level dependencies. Running pip-compile would then automatically generate a fully-pinned requirements.txt file, including all transitive dependencies (like altair).
This approach automates pinning, simplifies updates, and makes the entire dependency tree explicit and locked. It's a valuable practice for ensuring robust and maintainable dependency management as the project grows.
OpenJudge Version
[The version of OpenJudge you are working on, e.g.
import openjudge; print(openjudge.__version__)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
pre-commit run --all-filescommand