-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(model): support passing usage (e.g., cached_tokens) #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* feat: add metadata to the usage * fix(memory): fix the bug in redis memory that use bytes data as the message key
Summary of ChangesHello @MengsD, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the model usage reporting capabilities within AgentScope. By introducing a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for passing raw usage data from model APIs by introducing a metadata field to the ChatUsage class. The implementation is straightforward across the DashScope and OpenAI model wrappers.
However, there are a couple of points to address:
- Missing Tests: The repository's style guide (rule #38) requires that new features must include unit tests. This PR adds a new feature, but the corresponding tests in
tests/model_dashscope_test.pyandtests/model_openai_test.pyhave not been updated to verify that themetadatafield is correctly populated. Please add tests for this new functionality. The unchecked item[ ] All tests are passingin the PR description also suggests this needs attention. - Code Correction: I've found an issue in the definition of the new
metadatafield inChatUsagewhich will cause a runtime error, and a type hint mismatch. I've left a specific comment with a suggestion to fix it.
Once these points are addressed, the PR will be in good shape.
AgentScope Version
[The version of AgentScope you are working on, e.g.
import agentscope; print(agentscope.__version__)]1.0.10 (hot fix)
Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
pre-commit run --all-filescommand