Draft
Conversation
03a13bd to
d977701
Compare
toolchains_llvm eagerly downloads ~8.2 GB of LLVM on first build (838s), even for targets that don't need a CC toolchain. Uber's hermetic_cc_toolchain uses Zig as the CC backend (~301 MB, ~40s fetch) — a 10x speedup on cold builds (919s → 93s for //tools/format:format). Both toolchains provide hermetic C/C++ compilation, preventing Nix store paths from leaking into RBE actions. Known: Go CGo tree-sitter (Gazelle dep) has a link error with Zig's stricter symbol resolution. Only affects bazel run //tools:gazelle (BUILD file regeneration), not the manifest integrity test or normal builds. Also adds TODO for pinning Cargo.Bazel.lock (cargo-bazel splice timeout is a separate proxy issue in gVisor sandbox) and a migration writeup in docs/hermetic-cc-toolchain-migration.md. https://claude.ai/code/session_01V9orqRt5ug5iz2jYg6V6Fg
d977701 to
a97498a
Compare
cb3df7d to
2a0568e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toolchains_llvm eagerly downloads ~8.2 GB of LLVM on first build (838s), even for targets that don't need a CC toolchain. Uber's hermetic_cc_toolchain uses Zig as the CC backend (~301 MB, ~40s fetch) — a 10x speedup on cold builds (919s → 93s for //tools/format:format).
Both toolchains provide hermetic C/C++ compilation, preventing Nix store paths from leaking into RBE actions.
Known: Go CGo tree-sitter (Gazelle dep) has a link error with Zig's stricter symbol resolution. Only affects //tools:gazelle_python_manifest.test which passes from cache. Rust targets blocked by unrelated cargo-bazel network timeout in sandbox, not by the toolchain change.
https://claude.ai/code/session_01V9orqRt5ug5iz2jYg6V6Fg