Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
gomba999
force-pushed
the
make-cicd-lint-faster
branch
2 times, most recently
from
bc15f67 to
d197f5f
Compare
| cache-directories: | | ||
| ~/.cargo/bin | ||
| ~/.cargo/.crates.toml | ||
| ~/.cargo/.crates2.json |
There was a problem hiding this comment.
I'd tend to leave this as default instead of repearing it around, what do you think?
There was a problem hiding this comment.
My thinking was that without this the install of components with binstall would have to be forced every time so this let's us spare a little more time on the builds.
There was a problem hiding this comment.
100% agree, I am suggesting to put them as default in the action directly
There was a problem hiding this comment.
ah sorry I see now, I thought you meant the default as it is defined by the toolchain itself, I can set these to be the default values in the setup-rust workflow
Signed-off-by: Dominik Kolonits <dkolonit@cisco.com>
Signed-off-by: Dominik Kolonits <dkolonit@cisco.com>
Signed-off-by: Dominik Kolonits <dkolonit@cisco.com>
Signed-off-by: Dominik Kolonits <dkolonit@cisco.com>
Signed-off-by: Dominik Kolonits <dkolonit@cisco.com>
Signed-off-by: Dominik Kolonits <dkolonit@cisco.com>
Signed-off-by: Dominik Kolonits <dkolonit@cisco.com>
gomba999
force-pushed
the
make-cicd-lint-faster
branch
from
ff19cda to
3d0c62a
Compare
2 participants
Description
Fix typo in cache usage, disable caching cargo/bin since the swatinem cache used by the rust toolchain has a bug, add that as a directory instead. Disable cache for release builds.
Type of Change
Checklist