Skip to content

feat: multicast RPC support#1335

Open
msardara wants to merge 50 commits intomainfrom
slimrpc-updates-group
Open

feat: multicast RPC support#1335
msardara wants to merge 50 commits intomainfrom
slimrpc-updates-group

Conversation

@msardara
Copy link
Member

@msardara msardara commented Mar 6, 2026

Description

Fixes #1332

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

msardara added 30 commits March 3, 2026 12:05
@msardara
feat: slimrpc updates
5758d7b 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
03993cd 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
6708bca 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
c9ac6de 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
8f63508 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
60e1e2c 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
ff43dcc 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
272d9fa 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
7940fb3 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
Merge branch 'main' into slimrpc-updates
9d57e63 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
e957d0b 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
95e813d 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
fd6998e 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
f770fec 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
7d1c0e5 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: slimrpc updates
cc6373c 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
1042ea3 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
e772112 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
9997874 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
812a9a7 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
9d01936 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
954f4ec 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
16c9cd6 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
5950941 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
a9ac26c 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
955046f 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
26ac5bf 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
1ed1c29 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
b100804 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
a6be103 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
msardara added 12 commits March 5, 2026 19:24
@msardara
feat: multicast rpc
e9a597f 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
180fa4c 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
d716689 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
64300af 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
5d9f9cf 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
1554db2 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
0512b4e 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
7daf8d8 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
451e492 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
feat: multicast rpc
dc61b54 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
Merge branch 'main' into slimrpc-updates
31a695d
@msardara
feat: multicast rpc
f8613aa 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara msardara requested a review from a team as a code owner March 6, 2026 13:43
@msardara msardara self-assigned this Mar 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 18, 2026, 6:36 PM

@msardara msardara added the enhancement New feature or request label Mar 6, 2026
msardara added 3 commits March 6, 2026 16:06
@msardara
feat: fix logger
8486129 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara
Merge branch 'slimrpc-updates' into slimrpc-updates-group
9e53dc9
@msardara
fix: dotnet build
d38929f 
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara msardara linked an issue Mar 6, 2026 that may be closed by this pull request
Group RPC design proposal #1332
Open
micpapal
micpapal reviewed Mar 18, 2026
View reviewed changes
data-plane/bindings/rust/src/slimrpc/channel.rs

if received.is_eos() {
eos_count += 1;
if eos_count >= num_members { break; }
Copy link
Member

@micpapal micpapal Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should generate an error if eos_count > num_members?

data-plane/bindings/rust/src/slimrpc/channel.rs
);
if code != RpcCode::Ok {
let msg_text = String::from_utf8_lossy(&received.payload).to_string();
eos_count += 1;
Copy link
Member

@micpapal micpapal Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to receive multiple errors from the same remote? if yes the eos_counter is not enough and you need to track also the source of the packet.

Copy link
Member Author

@msardara msardara Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I will add the source as well

data-plane/bindings/rust/src/slimrpc/channel.rs
///
/// Returns an error if called on a P2P channel or if `destination` is
/// already a member.
pub async fn invite_participant(&self, destination: Name) -> Result<(), RpcError> {
Copy link
Member

@micpapal micpapal Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed as the group must remain static during the RPC

Base automatically changed from slimrpc-updates to main March 18, 2026 18:28
msardara added 3 commits March 18, 2026 19:29
@msardara
Merge remote-tracking branch 'origin/main' into slimrpc-updates-group
12f3204 
* origin/main:
  fix(README.md): correct youtube channel link (#1355)
  feat: java plugin for slimrpc compiler (#1342)
  fix: node_id override in slim service config (#1348)
  fix: cache usage (#1228)
  docs: update README with new bindings (#1339)
  feat: slim bindings for java (#1197)
@msardara
Merge branch 'main' into slimrpc-updates-group
1817ce5 
* main:
  feat(slimrpc): session reuse and method demultiplexing (#1334)
@msardara
Merge branch 'slimrpc-updates-group' of github.com:agntcy/slim into s…
911289a 
…limrpc-updates-group

* 'slimrpc-updates-group' of github.com:agntcy/slim:
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 88.98305% with 78 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
data-plane/bindings/rust/src/slimrpc/channel.rs 86.81% 60 Missing ⚠️
...ta-plane/bindings/rust/src/slimrpc/stream_types.rs 80.64% 18 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micpapal micpapal micpapal left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@msardara msardara

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Group RPC design proposal

2 participants

@msardara @micpapal