feat: Add slimrpc support for .NET (C#)#1345
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
1e30463 to
c9d0847
Compare
2cede71 to
4424175
Compare
There was a problem hiding this comment.
LGTM, with nits ✅
I get this warning when trying to build:
/Users/msardara/repos/slim/data-plane/bindings/dotnet/Slim.Examples.SlimRpc/Program.cs(143,52): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/Users/msardara/repos/slim/data-plane/bindings/dotnet/Slim.Examples.SlimRpc/Slim.Examples.SlimRpc.csproj]
Maybe we can add something like #pragma warning disable CS1998
data-plane/bindings/dotnet/Slim.Examples.SlimRpc/Generated/example_slimrpc.cs
Show resolved
Hide resolved
a7e5303 to
fd0e345
Compare
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
c341d49 to
6c672bf
Compare
Description
Resolves:
#1265
Type of Change
Checklist