Skip to content

feat: Add slimrpc support for .NET (C#)#1345

Open
janosSarusiKis wants to merge 12 commits intomainfrom
slimrpc-dotnet-#1265
Open

feat: Add slimrpc support for .NET (C#)#1345
janosSarusiKis wants to merge 12 commits intomainfrom
slimrpc-dotnet-#1265

Conversation

@janosSarusiKis
Copy link
Contributor

Description

Resolves:
#1265

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@janosSarusiKis janosSarusiKis self-assigned this Mar 10, 2026
@janosSarusiKis janosSarusiKis linked an issue Mar 10, 2026 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 18, 2026, 1:22 PM

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 97.04348% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
data-plane/slimrpc-compiler/src/csharp.rs 98.06% 11 Missing ⚠️
...mrpc-compiler/src/bin/protoc-gen-slimrpc-csharp.rs 0.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@janosSarusiKis janosSarusiKis changed the title Add slimrpc support for .NET (C#) feat: Add slimrpc support for .NET (C#) Mar 11, 2026
@janosSarusiKis janosSarusiKis marked this pull request as ready for review March 12, 2026 07:43
@janosSarusiKis janosSarusiKis requested a review from a team as a code owner March 12, 2026 07:43
@janosSarusiKis janosSarusiKis marked this pull request as draft March 12, 2026 07:47
@janosSarusiKis janosSarusiKis force-pushed the slimrpc-dotnet-#1265 branch 3 times, most recently from 2cede71 to 4424175 Compare March 13, 2026 09:34
@janosSarusiKis janosSarusiKis marked this pull request as ready for review March 13, 2026 09:35
Copy link
Member

@msardara msardara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with nits ✅

I get this warning when trying to build:

/Users/msardara/repos/slim/data-plane/bindings/dotnet/Slim.Examples.SlimRpc/Program.cs(143,52): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/Users/msardara/repos/slim/data-plane/bindings/dotnet/Slim.Examples.SlimRpc/Slim.Examples.SlimRpc.csproj]

Maybe we can add something like #pragma warning disable CS1998

Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Epic] Add slimrpc support for .NET (C#)

2 participants