Skip to content

feat: add link negotiation protocol between SLIM nodes#1353

Open
msardara wants to merge 11 commits intomainfrom
1351-add-link-negotiation-protocol-between-slim-nodes
Open

feat: add link negotiation protocol between SLIM nodes#1353
msardara wants to merge 11 commits intomainfrom
1351-add-link-negotiation-protocol-between-slim-nodes

Conversation

@msardara
Copy link
Member

@msardara msardara commented Mar 18, 2026

Description

Fixes #1351

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara msardara linked an issue Mar 18, 2026 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 18, 2026, 6:49 PM

Signed-off-by: Mauro Sardara <msardara@cisco.com>
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 95.21277% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
data-plane/core/datapath/src/message_processing.rs 96.60% 13 Missing ⚠️
data-plane/core/datapath/src/messages/utils.rs 86.36% 12 Missing ⚠️
data-plane/core/controller/src/service.rs 0.00% 1 Missing ⚠️
data-plane/core/slim/src/runner.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Mauro Sardara <msardara@cisco.com>
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara msardara force-pushed the 1351-add-link-negotiation-protocol-between-slim-nodes branch from 9e04450 to 7572032 Compare March 18, 2026 16:45
feat: add backwards compatibility testing
…lim-nodes

Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara msardara force-pushed the 1351-add-link-negotiation-protocol-between-slim-nodes branch from 7572032 to 6f09e0e Compare March 18, 2026 16:46
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Signed-off-by: Mauro Sardara <msardara@cisco.com>
@msardara msardara marked this pull request as ready for review March 18, 2026 17:53
@msardara msardara requested a review from a team as a code owner March 18, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add link negotiation protocol between SLIM nodes

1 participant