[Android] Allow to start a native fragment via Navigator.startNative().#129
Open
serj-lotutovici wants to merge 1 commit intoairbnb:masterfrom
Open
[Android] Allow to start a native fragment via Navigator.startNative().#129serj-lotutovici wants to merge 1 commit intoairbnb:masterfrom
serj-lotutovici wants to merge 1 commit intoairbnb:masterfrom
Conversation
serj-lotutovici
force-pushed
the
serj/native_screen_factory
branch
from
a0c3879 to
7aad397
Compare
* Introduces NativeScreenFactory for android.support.v4.app.Fragment. * Changes NavigatorModule.pushNative() to check for native screen availability. * Adds Native2Fragment to example app to show case usage of the new api. * ReactNavigationCoordinator throws exceptions early if no activity where registered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: I'm currently working on an existing app that due to historical reasons uses a ton of Fragments and there is a need to start a react-native scree, that could easily start a native fragment.