Add cifilter-builtins style guide rule#376
Open
stephenfurlani-cell wants to merge 1 commit intoairbnb:masterfrom
Open
Add cifilter-builtins style guide rule#376stephenfurlani-cell wants to merge 1 commit intoairbnb:masterfrom
stephenfurlani-cell wants to merge 1 commit intoairbnb:masterfrom
Conversation
Prefer CIFilter typed factory methods (CIFilterBuiltins) over string-based CIFilter(name:) and setValue(_:forKey:). Adds rule entry to the Patterns section immediately before File Organization. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
calda
reviewed
Apr 16, 2026
| // RIGHT | ||
| let url = #URL("https://example.com") | ||
| import CoreImage.CIFilterBuiltins |
Member
There was a problem hiding this comment.
Can this be just import CoreImage or do you need to specifically import CoreImage.CIFilterBuiltins in addition to CoreImage?
calda
approved these changes
Apr 16, 2026
Member
calda
left a comment
calda
left a comment
There was a problem hiding this comment.
Looks nice thanks! Could you please move it to the new "Apple Frameworks" section of the style guide, and run the markdown linter? (bundle exec rake lint:markdown)
calda
reviewed
Apr 16, 2026
Member
There was a problem hiding this comment.
Put the rule above the section's back to top button (as opposed to adding a new one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer CIFilter typed factory methods (CIFilterBuiltins) over string-based CIFilter(name:) and setValue(_:forKey:). Adds rule entry to the Patterns section immediately before File Organization.
Summary
Adds a new Patterns rule recommending
CIFilter's typed factory methods (fromCIFilterBuiltins) over the string-basedCIFilter(name:)initializer and KVOsetValue(_:forKey:).No SwiftLint or SwiftFormat rule exists for this — it is a style guide entry only.
Reasoning
CIFilter(name:)returns an optional and requires stringly-typed KVO for parameter access. TheCIFilterBuiltinsfactory methods (available since iOS 14) provide non-optional returns and compile-time type-checked properties, eliminating an entire class of runtime errors.The typed API requires
import CoreImage.CIFilterBuiltins, which is an unusual submodule import but is Apple's documented approach.Reference: https://developer.apple.com/documentation/coreimage/processing-an-image-using-built-in-filters