Fix PHP 8.x TypeError: cast AJAX numeric params to int before arithmetic#263
Open
TeleDark wants to merge 1 commit into
Open
Fix PHP 8.x TypeError: cast AJAX numeric params to int before arithmetic#263TeleDark wants to merge 1 commit into
TeleDark wants to merge 1 commit into
Conversation
On PHP 8.0+, arithmetic on strings throws a fatal TypeError. AJAX params from filter_input_array(INPUT_GET) are always strings, so performing math directly on them causes 'Unsupported operand types: string * string'. Affected line: $args['offset'] = $offset + ( $posts_per_page * $page ); Variables $offset, $posts_per_page, $page and $preloaded_amount were all read from $params without type casting. Fix: cast all four variables to (int) at point of assignment. Tested on PHP 8.4. No functional change on PHP 7.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On PHP 8.0+, arithmetic on strings throws a fatal TypeError. AJAX params from filter_input_array(INPUT_GET) are always strings, so performing math directly on them causes 'Unsupported operand types: string * string'.
Affected line:
$args['offset'] = $offset + ( $posts_per_page * $page );
Variables $offset, $posts_per_page, $page and $preloaded_amount were all read from $params without type casting.
Fix: cast all four variables to (int) at point of assignment.
Tested on PHP 8.4. No functional change on PHP 7.x.