bug: Fix conditional check for metrics existing secret#333
Open
appkins wants to merge 1 commit intoakeylesslabs:mainfrom
Open
bug: Fix conditional check for metrics existing secret#333appkins wants to merge 1 commit intoakeylesslabs:mainfrom
appkins wants to merge 1 commit intoakeylesslabs:mainfrom
Conversation
appkins
force-pushed
the
patch-1
branch
2 times, most recently
from
23f31b3 to
0905a74
Compare
Author
|
Any chance a team member can review this PR? This code fixes a breaking bug when enabling metrics without a secret. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for mounting the metrics configuration in the
charts/akeyless-gateway/templates/deployment.yamlfile. The change ensures that the metrics configuration is only mounted when both metrics are enabled and an existing metrics secret is provided.Metrics configuration logic update:
otelcol-metrics-configvolume to require both.Values.globalConfig.metrics.enabledand.Values.globalConfig.metrics.metricsExistingSecretto be true, instead of checking.Values.globalConfig.metrics.enabledtwice.