[Persistence] Add supervisor strategy to journal and snapshot options#602
[Persistence] Add supervisor strategy to journal and snapshot options#602Arkatufus wants to merge 2 commits intoakkadotnet:devfrom
Conversation
Aaronontheweb
left a comment
There was a problem hiding this comment.
Why not just assign a SupervisionStrategy directly?
|
Because the way it is set up in Akka, it requires a |
There was a problem hiding this comment.
the goal is to assign a supervisor strategy
- the
SupervisorConfiguratoror whatever it's called is a hack we have to have in order to get HOCON to work. - We can just do the
SupervisorStrategydirectly here and generate the configurator for it. That would be the DX-friendly way to do this.
|
Yes, but that is not how the supervisor strategy being loaded from HOCON the HOCON loader requires that the type being passed in as a |
|
We can't just "generate" a configurator because it still needs to be loaded from HOCON in the end. And as you said, "the SupervisorConfigurator or whatever it's called is a hack we have to have in order to get HOCON to work". You mean actually use code generator to make a class during compilation time? |
Changes
Add
JournalOptions.SupervisorStrategyandSnapshotOptions.SupervisorStrategyoptions that was added to Akka v1.5.42