[FIX] err is reinitialized since used in except Exception#10
Closed
remi-filament wants to merge 1 commit into
Closed
[FIX] err is reinitialized since used in except Exception#10remi-filament wants to merge 1 commit into
remi-filament wants to merge 1 commit into
Conversation
|
Hi @alexis-via, |
remi-filament
force-pushed
the
18.0-fix-l10n_fr_einvoicing
branch
from
June 22, 2026 09:05
a1c84d3 to
81c4170
Compare
remi-filament
added a commit
to lefilament/fr-einvoicing
that referenced
this pull request
Jun 23, 2026
|
LGTM |
remi-filament
force-pushed
the
18.0-fix-l10n_fr_einvoicing
branch
from
July 10, 2026 17:36
81c4170 to
c61a7d7
Compare
Contributor
Author
|
Covered in #22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When import fails,
an exception is caught by
fr-einvoicing/l10n_fr_einvoicing/models/fr_einvoicing_flow.py
Line 604 in ecbf6f2
This uses err as Exception and therefore err does not exist anymore when you go back to execution later and if err: on line 624 raises a traceback :