Security: Fix 3 findings in GitHub Actions workflows - #2841
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
bf90643 to
f9b18c3
Compare
21b0fda to
f9b18c3
Compare
|
Thanks for working on this. Moving untrusted GitHub event text out of inline In echo '$COMMENT_BODY'uses single quotes, so the shell will not expand the variable. That means
I think this should be changed to a form that still avoids inline GitHub expression interpolation but allows normal shell expansion (for example Also, |
Security: 3 findings across 1 rule
Fixed (deterministic, no AI)
shell-injection-expr — What is this?
claude.ymlline 58: Attacker-controllable expression ${{ github.event.comment.body }} in run: block — shell injection riskissue.ymlline 19: Attacker-controllable expression ${{ github.event.issue.body }} in run: block — shell injection riskRequires manual review
shell-injection-expr — What is this?
claude.ymlline 70: Attacker-controllable expression ${{ github.event.comment.body }} in run: block — shell injection riskHow this was detected
This finding was identified by deterministic pattern matching — no AI or machine learning was used in the detection. Sentinel uses static analysis rules that match known-vulnerable YAML patterns against a database of documented exploit vectors. Every finding maps to a specific, reproducible pattern. Source code is open for inspection.
🛡️ This PR was generated by Sentinel, an open-source security scanner. Why this PR? · Free, no tracking
✅ Add Sentinel to this repo · 🚫 Opt out of future PRs