Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the project to use Symfony 7 and PHP 8.5, modernizing the codebase through migration to PHP 8 attributes and updated method signatures.
Changes:
- Updated minimum PHP version requirement to 8.5 and Symfony dependencies to 7.4
- Migrated Doctrine ORM annotations to PHP 8 attributes in entity classes
- Replaced PHPUnit
@dataProviderannotations with#[DataProvider]attributes - Updated voter method signatures to include the new optional
Voteparameter introduced in Symfony 7
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updated PHP version to 8.5 and Symfony/Doctrine dependencies to version 7.4/3.6+ |
| .github/workflows/ci.yaml | Updated CI matrix to test only PHP 8.5 |
| tests/PermissionTest.php | Migrated @dataProvider annotations to #[DataProvider] attributes |
| src/Security/Voter/SetPermissionVoter.php | Added optional Vote parameter to voteOnAttribute method signature |
| src/Security/Voter/AclVoter.php | Added optional Vote parameter and imported Vote class |
| src/Entity/AccessControlEntry.php | Converted all Doctrine ORM annotations to PHP 8 attributes |
| src/Controller/PermissionController.php | Formatted constructor with trailing comma and modernized syntax |
| src/Admin/PermissionView.php | Modernized closure to use first-class callable syntax |
| rector.php | Added attributes set configuration for automated migration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.