Fix message forwarding bug, wire up peer metrics, and clean up dead code#66
Merged
Fix message forwarding bug, wire up peer metrics, and clean up dead code#66
Conversation
aliel
force-pushed
the
aliel-enh-add-metrics
branch
from
0c62dc5 to
23c7aae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-JSON P2P messages were silently dropped instead of being forwarded to RabbitMQ.
JSON parsing is now best-effort for logging only.
removed unused metrics/structs, and wired up the connected_peers gauge to track live P2P connections.