Skip to content

Fixed UnsubscribeArticleCreation to delete unsubscribing observer #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgloutnikov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed UnsubscribeArticleCreation to delete unsubscribing observer #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4df1c9
Fixed UnsubscribeArticleCreation to delete unsubscribing observer fro…
sgloutnikov Mar 12, 2021
0f5ff9e
Renamed subscriber to observer in loop
sgloutnikov Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions service/article_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,15 @@ func (svc *ArticleService) SubscribeArticleCreation() *ArticleServiceObserver {
func (svc *ArticleService) UnsubscribeArticleCreation(observer *ArticleServiceObserver) {
svc.mutex.Lock()
close(observer.CreationStream)
j := 0
for _, entry := range svc.articleCreationObservers {
if entry == observer {
svc.articleCreationObservers[j] = entry
for i, obs := range svc.articleCreationObservers {
if obs == observer {
// Remove from slice. Copy last element to the position of to be deleted element and truncate slice.
svc.articleCreationObservers[i] = svc.articleCreationObservers[len(svc.articleCreationObservers)-1]
svc.articleCreationObservers[len(svc.articleCreationObservers)-1] = nil
svc.articleCreationObservers = svc.articleCreationObservers[:len(svc.articleCreationObservers)-1]
break
}
}
svc.articleCreationObservers = svc.articleCreationObservers[:j]
svc.mutex.Unlock()
}

Expand Down