Strip brackets from IPv6-literal hosts before TLS SNI/ServerName#1171
Merged
Conversation
`Authority::host()` returns IPv6 literals in their URI-syntax bracketed form (e.g. `[::1]`), but rustls' `ServerName::try_from` rejects the brackets, so HTTPS against an IPv6-literal URL failed the TLS handshake. Add `AuthorityExt::host_bare()` to yield the unbracketed host and use it when passing the name to rustls and native-tls. Fixes #1168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authority::host()returns IPv6 literals in their URI-syntax bracketed form (e.g.[::1]), per RFC 3986.ServerName::try_fromrejects the brackets, so HTTPS to an IPv6-literal URL (e.g.https://[::1]/, link-local[fe80::...]) fails the TLS handshake with "invalid dns name". native-tls has the same problem — brackets aren't valid for SNI.AuthorityExt::host_bare()insrc/util.rsthat strips the surrounding[/]when present, and use it in both the rustls and native-tls connectors. DNS names and IPv4 literals are unaffected.ServerName::IpAddress, which matches the iPAddress SAN — i.e. no extension to rustls is needed.Fixes #1168.