Skip to content

feat(recommend): add Trending-Facets model - #6556

Closed
raed667 wants to merge 17 commits into
masterfrom
feat/recommend/trending-facets
Closed

feat(recommend): add Trending-Facets model#6556
raed667 wants to merge 17 commits into
masterfrom
feat/recommend/trending-facets

Conversation

@raed667

@raed667 raed667 commented Feb 10, 2025

Copy link
Copy Markdown
Contributor

Summary

Add Recommend model trending-facets

TODO

  • Figure out what to do with sendEvent (Recommend analytics does not support trending-facets)
  • Implement tests

@raed667
raed667 requested review from aymeric-giraudet, dhayab, marialungu and sarahdayan and removed request for marialungu February 10, 2025 07:16
@codesandbox-ci

codesandbox-ci Bot commented Feb 10, 2025

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d78546b:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@raed667
raed667 force-pushed the feat/recommend/trending-facets branch 2 times, most recently from 6e760d8 to bc997e5 Compare February 10, 2025 07:56
@raed667

raed667 commented Feb 10, 2025

Copy link
Copy Markdown
Contributor Author

@algolia/frontend-experiences-web hi team, this is not urgent, but can someone help figure out go the fix the V4 types 🙏 ?

Comment thread packages/instantsearch.js/src/connectors/trending-facets/types.ts Outdated
@raed667
raed667 force-pushed the feat/recommend/trending-facets branch 2 times, most recently from c077e94 to c02fee6 Compare February 10, 2025 09:04
Comment thread packages/instantsearch-ui-components/src/components/TrendingFacets.tsx Outdated
@raed667
raed667 force-pushed the feat/recommend/trending-facets branch from c02fee6 to 9137cc8 Compare February 10, 2025 10:08
Comment thread packages/instantsearch-ui-components/src/components/TrendingFacets.tsx Outdated
@raed667
raed667 force-pushed the feat/recommend/trending-facets branch 3 times, most recently from 2806db3 to be5ab5c Compare February 11, 2025 10:37
@Haroenv

Haroenv commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

Originally we didn't implement trending facets as it's not clear how we want to incorporate the filtering / links inside it, as it could be many different attributes, refinement types.

However, it makes sense to be able to fully deprecate the old recommend widgets, and so we'll need trending facets too.

What we'll need to be able to later create a filtering directly from this widget I think is to make the itemComponent required here, so changing the default isn't a breaking change.

@Haroenv
Haroenv force-pushed the feat/recommend/trending-facets branch from 121fc18 to 5bfd850 Compare June 23, 2025 09:15
@Haroenv
Haroenv force-pushed the master branch 3 times, most recently from c1fa2e8 to 9af869e Compare December 31, 2025 14:19
@raed667

raed667 commented Apr 8, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #6957

@raed667 raed667 closed this Apr 8, 2026
@Haroenv
Haroenv deleted the feat/recommend/trending-facets branch June 25, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants